Rich text: highlight format: gracefully handle old span format #56071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -127 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ellatrix
added
[Type] Code Quality
ellatrix
force-pushed
the
fix/rich-text-color-upgrade
branch
from
880cef4 to
f23a040
Compare
dmsnell
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Since #52423, rich text no longer forcefully “upgrades” a tag name of a format if it doesn’t match the tag name declared by the format type. This allows us to remove all the logic (introduced in #35516) for adding a background color when a highlight format still uses the old span markup, because we will now leave the span in place. It also allows us to remove the logic that dirties the editor for this upgrade.
Why?
The reasoning behind this is not only simplicity, but also leaving existing markup alone. It's needed for #43204, which relies on
createnot modifying existing markup.How?
#52423 made a change that allows existing tag names to be preserved.
Testing Instructions
Create a post with the following old highlight markup
Ensure that the the text in the editor is correctly coloured. Also ensure that when putting the caret in the text, the highlight button in the rich text dropdown is active. This means the format is properly recognised as a highlight.
Testing Instructions for Keyboard
Screenshots or screencast