Update main toolbar buttons to all be compact #56635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: -52 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Nov 30, 2023
| @@ -1,7 +1,7 @@ | |||
| .edit-site-document-actions { | |||
| display: flex; | |||
| align-items: center; | |||
| height: $button-size; | |||
| height: 32px; | |||
There was a problem hiding this comment.
You could use the $button-size-compact sass variable here
jameskoster
approved these changes
Nov 30, 2023
jasmussen
force-pushed
the
try/compact-buttons-alt
branch
from
e6e9c4f to
098a161
Compare
|
Wanted to note these icons on the left have no gap between them, while the right side does. Was this intentional?
|
|
I could've sworn I tested that. Not intentional (should be 8px gap just like the block toolbar), and I will follow up 👍 👍 |
igorschoester
added a commit
to Yoast/wordpress-seo
that referenced
this pull request
Jan 8, 2024
With Gutenberg 17.3 (PR WordPress/gutenberg#56635) All the button icons are now displayed as "compact", which makes the width 32px (from 36px). This change makes it so we have no space around the icon (horizontally). This change removes the icon size override, reverting it back to be 24px. Leaving it with the expected 8px spacing.
igorschoester
added a commit
to Yoast/wordpress-seo
that referenced
this pull request
Jan 8, 2024
With Gutenberg 17.3 (PR WordPress/gutenberg#56635) All the button icons are now displayed as "compact", which makes the width 32px (from 36px). This change makes it so we have no space around the icon (horizontally). This change removes the icon size override when in compact mode, reverting it back to be 24px. Leaving it with the expected 8px spacing.
igorschoester
added a commit
to Yoast/wordpress-seo
that referenced
this pull request
Jan 8, 2024
With Gutenberg 17.3 (PR WordPress/gutenberg#56635) all the button icons are now displayed as "compact", which makes the width 32px (from 36px). Resulting in no space around the icon (horizontally). This change removes the icon size override when in compact mode. Effectively reverting the icon size back to be 24px. Leaving the same horizontal space as the WP icons.
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #55079, with a smaller footprint. Make progress on #46734 by updating buttons in the top toolbar to be compact, ensuring that icon buttons, and inserter all have the same balance, where in trunk at the moment it's a mix of 32 and 36px, with subsequently uneven spacing and margins.
Post editor before:
after:
Site editor before:
after:
PR review feedback from the other PR is likely still relevant, but it has also been considered for this PR.
Testing Instructions
Test the buttons in the main toolbar at the top of the post and site editors. Functionally it should all be the same.