Editor: Unify revision panel between post and site editors #57010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
jameskoster,
jasmussen,
mikachan,
glendaviesnz,
chad1008 and
a team
|
The design and placement of this button could use some love, but this is working for me. One question though; when you land on the revisions view, there's a "← Go to editor" link... the arrow suggests a move backwards, but that's not the case if you came from the site editor – you get sent to the post editor instead. Is there anything we can do about that? |
I don't think we can do much, it's an existing issue, you can see it in the revisions panel of the patterns in trunk too. I think ultimately, we need a canonical place to edit a page or a post, and this won't happen before the grand redesign right. |
|
Size Change: -180 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ee9a058. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7195059269
|
|
Fair enough. A small bandaid would be to simply remove the arrow glyph, but it's a tiny detail. |
jameskoster
approved these changes
Dec 13, 2023
bph
added
the
[Feature] Site Editor
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
This PR continues the work on the great unification between post and site editors. This PR unifies the PostLastRevisionPanel component. It also adds the panel to the page sidebar on the site editor, it was only present for synced patterns in the site editor.
Testing instructions
Left: Post Editor, Right: Site Editor