Dependency Extraction Webpack Plugin: Use import for module externals
#57577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `module` externals, webpack always produces a static import: import x from 'external-module'; That's undesirable in the case of dynamic imports where module loading could be deferred or avoided altogether. Instead, use the `import` external type which causes webpack use always use `import()` to load these external modules.
sirreal
force-pushed
the
dewp-use-import-not-modules
branch
from
0377de5 to
7cfb82e
Compare
gziolo
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
luisherranz
approved these changes
Jan 5, 2024
|
Ups, I didn't notice the auto-merge was enabled. My bad 😄 |
|
I love having relevant changelogs, but since this feature hasn't shipped I think it's covered under the new feature. I can add one in another PR if desired. |
true! |
sirreal
added a commit
that referenced
this pull request
Jan 5, 2024
…ivity (#57602) Use an explicit module external type by default for the @wordpress/interactivity external module. In #57577, we switched the default external type from module (externals are always hoisted to static imports) to import (externals are always dynamic import()s). That's likely desirable for most external modules, but @wordpress/interactivity has some known issues where it may not behave as expected if it's not initialized before DOMContentLoaded (#56986). By declaring an explicit module external type for @wordpress/interactivity, webpack will always hoist this import to a static import, preventing issues with dynamic imports of the package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use
importinstead ofmoduleas the external type. This prevents webpack from hoisting all external modules to static imports —even ones that were written as dynamic/asyncimport()!Why?
See https://webpack.js.org/configuration/externals/#externalstype
With
module, all external modules were hoisted to static imports. That has some downsides, in particular making it completely irrelevant to use dynamic imports in code to defer or avoid loading some modules.importtransforms all the externals to dynamicimport(…).Webpack behavior
Input
Notice the dynamic
import():Before
Notice the import is now hoisted to a static import:
After
Here we restore the dynamic
import():