Zoom out mode: only apply grey background for mode #59377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +102 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
t-hamano
added
[Type] Experimental
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
t-hamano
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
LGTM!
- ✅ I have confirmed that the issue reported in Block Editor: Gray background color appears behind theme background color #59348 is resolved.
- ✅ When the theme does not have a background color, a default white background color will be applied in the zoomed out view.
- ✅ This default white background can be overridden correctly from the global styles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #59348. See #59334.
Additionally we might have to make sure
bodyhas default (white) styling. What do you think?Why?
Background shouldn't be applied if the mode is not applied.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast