Zoom out: keep original viewport width (single scale) #61424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.75 kB (+0.1%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
ajlende
commented
May 8, 2024
Comment on lines
242
to
245
| ? scaleProp( { | ||
| containerWidth, | ||
| windowInnerWidth, | ||
| } ) |
There was a problem hiding this comment.
The signature of this function changed, but the old function didn't make it into 6.5, so I think it's okay, but it might be a good idea to make the scale as a function a private API before the 6.6 release. We might want to move some of the logic elsewhere.
ellatrix
reviewed
May 8, 2024
packages/edit-site/src/components/block-editor/editor-canvas.js
Outdated
Show resolved
Hide resolved
ellatrix
approved these changes
May 8, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ajlende
added
[Type] Enhancement
Conflicts: packages/edit-site/src/components/block-editor/editor-canvas.js packages/editor/src/components/editor-canvas/utils.js
mikachan
reviewed
May 8, 2024
There was a problem hiding this comment.
I think this is a good alternative to #61422, but I noticed that the preview is no longer centered - there seems to be more spacing on the right side compared to the left. Maybe this could be addressed in a follow-up:
| Trunk | This PR |
|---|---|
 |
 |
Conflicts: packages/block-editor/src/components/iframe/index.js
This seems resolved to me |
scruffian
reviewed
May 10, 2024
|
I think this PR broke the "height" prop of the BlockCanvas component and a few other things. I'll try to see if I can fix it. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #61422
What?
Makes the zoom out view show a full-width page.
Why?
This avoids layout shifting when you zoom out.
How?
100vw.100vwand the container width.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast