Query Loop: Fix 'block' scoped variations to get the query defaults
#63477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
reviewed
Jul 12, 2024
| @@ -122,6 +122,7 @@ function QueryVariationPicker( { | |||
| setAttributes( { | |||
| ...variation.attributes, | |||
| query: { | |||
| ...attributes.query, | |||
| ...variation.attributes.query, | |||
| postType: | |||
There was a problem hiding this comment.
I actually don't understand why we're doing this, Why are we overriding namespace and post type here?
There was a problem hiding this comment.
I think we should just call setAttributes( variation.attributes ) since this variation picked is only used when starting blank.
There was a problem hiding this comment.
I think we should just call setAttributes( variation.attributes )
Hm.. that could work now. If I remember correctly, this was needed because before we intentionally had the inherit:false and since properties of object attributes are not merged, we needed to also provide the rest of the props in the variation declaration. But since we could be here from another inserter Query variation, we needed to respect some important attributes like postType. I'll update to just set the attributes then.
There was a problem hiding this comment.
Ah.. it's also about this PR: #46410. namespace is used in order to be able to connect variations with variations 😄 . So we cannot do just setAttributes..
There was a problem hiding this comment.
namespace is used in order to be able to connect variations with variations 😄 . So we cannot do just setAttributes..
What? I don't understand this sentence, can you clarify?
There was a problem hiding this comment.
I'm understand the issue more, I think combining "block variations" with "inserter variations" was a mistake from the start. Do we know of people actually using that or is it theoretical?
There was a problem hiding this comment.
Here's another proposal: "block variations" shouldn't update the query attribute at all, they should just update the inner blocks. So what about removing the setAttributes here entirely?
There was a problem hiding this comment.
IF you provide a variation for the query block, you don't need to show the "block scoped variations" at all, you're not starting blank as you picked a variation no?
Not necessarily. You can register variations that don't provide inner blocks.
I'm understand the issue more, I think combining "block variations" with "inserter variations" was a mistake from the start. Do we know of people actually using that or is it theoretical?
There were many issues from extenders and was definitely used. Not sure if some plugins still use it, but there was a lot of traction to get this working. I think the combination of block and inserter variations stems from the complexity of this specific block and that's why there was a local implementation.
Here's another proposal: "block variations" shouldn't update the query attribute at all, they should just update the inner blocks. So what about removing the setAttributes here entirely?
This should be a breaking change, no?
There was a problem hiding this comment.
This should be a breaking change, no?
I don't think so. For me, it just clarifies the behavior. "Inserter" is about defining the whole block, "block" scoped variations is about the content (which is already the case btw)
There was a problem hiding this comment.
This makes sense. Let's try this.
|
Size Change: +156 B (+0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
ntsekouras
force-pushed
the
fix-block-scoped-variations-query
branch
from
29e3c3b to
d2fdb57
Compare
youknowriad
approved these changes
Jul 15, 2024
ntsekouras
force-pushed
the
fix-block-scoped-variations-query
branch
from
d2fdb57 to
8bee67c
Compare
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…WordPress#63477) Co-authored-by: ntsekouras <[email protected]> Co-authored-by: youknowriad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up of: #63353
The intention of the linked PR was to allow the
blockscoped Query Loop variations to get the default query values and especially theinherit: truevalue. That PR did would normally work, but with the nuances ofobjecthandling attributes in GB and specifically also in Query Loop which has other nuances, we need to make the changes in this PR too.Testing Instructions
1- Insert Query Loop block
2- Click "Start blank"
3- Pick one of the proposed variations
4- Notice that the inserted query has the "inherit" toggle enabled.