Zoom Out: Only show the inserters when a block is selected or hovered #63668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Enhancement
scruffian
requested review from
ellatrix,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +286 B (+0.02%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
scruffian
commented
Jul 18, 2024
scruffian
commented
Jul 18, 2024
packages/block-editor/src/components/block-tools/zoom-out-mode-inserter-button.js
Outdated
Show resolved
Hide resolved
scruffian
commented
Jul 18, 2024
packages/block-editor/src/components/block-tools/zoom-out-mode-inserter-button.js
Outdated
Show resolved
Hide resolved
scruffian
commented
Jul 18, 2024
packages/block-editor/src/components/block-tools/zoom-out-mode-inserter-button.js
Outdated
Show resolved
Hide resolved
scruffian
commented
Jul 18, 2024
packages/block-editor/src/components/block-tools/zoom-out-mode-inserter-button.js
Outdated
Show resolved
Hide resolved
scruffian
commented
Jul 18, 2024
scruffian
commented
Jul 18, 2024
scruffian
commented
Jul 18, 2024
jeryj
reviewed
Jul 18, 2024
Comment on lines
56
to
58
| const isHovered = | ||
| hoveredBlockClientId === previousClientId || | ||
| hoveredBlockClientId === nextClientId; |
Comment on lines
26
to
49
| const { | ||
| sectionRootClientId, | ||
| setInserterIsOpened, | ||
| hasSelection, | ||
| selectedBlockClientId, | ||
| hoveredBlockClientId, | ||
| } = useSelect( ( select ) => { | ||
| const { | ||
| getSettings, | ||
| getSelectionStart, | ||
| getSelectedBlockClientId, | ||
| getHoveredBlockClientId, | ||
| } = select( blockEditorStore ); | ||
| const { sectionRootClientId: root } = unlock( getSettings() ); | ||
|
|
||
| return { | ||
| hasSelection: !! getSelectionStart().clientId, | ||
| sectionRootClientId: root, | ||
| setInserterIsOpened: | ||
| getSettings().__experimentalSetIsInserterOpened, | ||
| selectedBlockClientId: getSelectedBlockClientId(), | ||
| hoveredBlockClientId: getHoveredBlockClientId(), | ||
| }; | ||
| }, [] ); |
There was a problem hiding this comment.
Seems like some of this could be passed into the component from ZoomOutModeInserters rather than doing the work again here.
jeryj
reviewed
Jul 18, 2024
jeryj
approved these changes
Jul 18, 2024
We want to show the inserters on hover, even if there is no selection.
…-inserter-button.js
…-inserter-button.js
…-inserter-button.js
…-inserter-button.js
scruffian
force-pushed
the
update/zoom-out-inserters
branch
from
59adab5 to
ff91cb0
Compare
97 tasks
|
I think it's worth keeping an eye on this behavior. While debugging #68875, it was odd that hovering was updating store subscribers until I saw this change. Now, just moving the cursor on the canvas can re-render multiple blocks. Maybe we should defer dispatching the store updates with a pattern similar to a "hover intent". IMO, new selectors/actions should have been private. We missed some of those for the Zoom Out feature and shipped them as public. I'm not sure if it's too late to revert. cc @WordPress/gutenberg-core |
|
I recall that prior to this PR, I did work on this #44325 to avoid calling actions synchronously when moving the mouse. So it seems that you're suggesting that this PR kind of reverts that right? If it's the case, I'm with you, this is problematic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
At the moment in Zoom Out mode the inserters always show. This updates the zoom out inserters so that they only show if either, the block is selected, or the block is hovered.
Why?
It's not helpful to show too many inserters, its better to only show the ones we need.
How?
Testing Instructions
Screenshots or screencast