Try: deal with duplicate color slugs #65597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +448 B (+0.03%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ramonjd
force-pushed
the
try/custom-presets-ignore-duplicate-slugs
branch
from
136da56 to
ed20316
Compare
ramonjd
force-pushed
the
try/custom-presets-ignore-duplicate-slugs
branch
from
ed20316 to
d2fac65
Compare
|
Flaky tests detected in d2fac65. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11339366038
|
|
#65772 prevents adding duplicate slugs in the first place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
valueand/orname#43197PaletteEdit: dedupe palette element slugs #65772A test branch to illustrate how the UI might deal with existing, custom duplicate custom color slugs.
What?
Why?
How?
Testing Instructions
Test theme.json
{ "$schema": "../../schemas/json/theme.json", "version": 3, "settings": { "appearanceTools": true, "color": { "duotone": [ { "colors": ["#111111", "#ffffff"], "slug": "duotone-1", "name": "Black and white" }, { "colors": ["#111111", "#C2A990"], "slug": "duotone-1", "name": "Black and white" }, { "colors": ["#111111", "#D8613C"], "slug": "duotone-1", "name": "Black and rust" }, { "colors": ["#111111", "#B1C5A4"], "slug": "duotone-4", "name": "Black and sage" } ], "gradients": [ { "slug": "gradient-1", "gradient": "linear-gradient(to bottom, #cfcabe 0%, #F9F9F9 100%)", "name": "Vertical soft beige to white" }, { "slug": "gradient-1", "gradient": "linear-gradient(to bottom, #C2A990 0%, #F9F9F9 100%)", "name": "Vertical soft beige to white" }, { "slug": "gradient-1", "gradient": "linear-gradient(to bottom, #D8613C 0%, #F9F9F9 100%)", "name": "Vertical soft rust to white" }, { "slug": "gradient-4", "gradient": "linear-gradient(to bottom, #B1C5A4 0%, #F9F9F9 100%)", "name": "Vertical soft sage to white" } ], "palette": [ { "color": "#f9f9f9", "name": "Base", "slug": "base" }, { "color": "#ffffff", "name": "Base", "slug": "base" }, { "color": "#111111", "name": "Contrast", "slug": "base" }, { "color": "#636363", "name": "Contrast / Two", "slug": "contrast-2" } ] } } }Testing Instructions for Keyboard
Screenshots or screencast
Kapture.2024-09-24.at.16.57.47.mp4
Kapture.2024-09-26.at.11.52.10.mp4