Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Rename "Edit site" to "Design" and make it consistently visible in the admin bar #66894

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

ptesei
Copy link

@ptesei ptesei commented Nov 10, 2024

What?

  • Rename "Edit site" to "Design"
  • Make it consistently visible in the admin (including admin and multisite admin)
  • Consistently redirect to the site editor main view.

Why?

Fixes: #63785
Screenshot 2024-11-10 at 21 17 33

Screenshot 2024-11-10 at 21 17 41

@ptesei ptesei requested a review from spacedmonkey as a code owner November 10, 2024 21:21
Copy link

github-actions bot commented Nov 10, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ptesei <[email protected]>
Co-authored-by: annezazu <[email protected]>
Co-authored-by: richtabor <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: ndiego <[email protected]>
Co-authored-by: bph <[email protected]>
Co-authored-by: markhowellsmead <[email protected]>
Co-authored-by: sethrubenstein <[email protected]>
Co-authored-by: bacoords <[email protected]>
Co-authored-by: andreawetzel <[email protected]>
Co-authored-by: colorful-tones <[email protected]>
Co-authored-by: luminuu <[email protected]>
Co-authored-by: paaljoachim <[email protected]>
Co-authored-by: JosVelasco <[email protected]>
Co-authored-by: unscripted <[email protected]>
Co-authored-by: jorgefilipecosta <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 10, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @ptesei! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@akasunil akasunil added the [Type] Enhancement A suggestion for improvement. label Nov 12, 2024
@annezazu
Copy link
Contributor

I don't think we should move forward with this as it moves away from the convention for "Edit post" and requires greater design thinking. I also don't see how it fixes #63785

@ptesei
Copy link
Author

ptesei commented Nov 30, 2024

hello @annezazu i've update the PR.
I agree with you tha absolutly greater design thinking is needed !
the point is that the the convention for "Edit post" are Classic WordPress conventions
Edit site belongs to the new Gutenber conventions and it really should be ubiquitous IMHO.
The fix is 'href' => admin_url( 'site-editor.php' )

@richtabor
Copy link
Member

Do you mind updating the title/description/visual to map to your latest changes? Thanks!

@carolinan
Copy link
Contributor

Hi @ptesei Are you available to continue working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the “Edit site” admin bar control to open the Site Editor at the top-level, consistently
5 participants