Inserter: Set initial active tab ID during render #67103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Inserter
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -11 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
tyxla
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Code change makes sense, however, I'm unable to make this work - both in trunk and this PR.
Am I missing something? I expected "All" will get focused when I click on Patterns, but I didn't see it happening (I also tried navigating with tabbing).
Screen.Recording.2024-11-19.at.15.55.47.mov
|
Flaky tests detected in 1c7b946. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11909377374
|
|
@tyxla, sorry for the confusion. When navigating the category list after opening the Patterns, the first category should receive focus. It usually takes two Tab presses. I've updated the description and added the screencast. |
|
Thanks for testing and review, @tyxla 🙇 |
ellatrix
reviewed
Nov 29, 2024
| // when focus is moved to the tablist, the first tab will be focused | ||
| // despite not being selected | ||
| if ( selectedTabId === null && ! activeTabId && firstTabId ) { | ||
| setActiveId( firstTabId ); |
There was a problem hiding this comment.
We shouldn't set state during render?
There was a problem hiding this comment.
@ellatrix see https://react.dev/learn/you-might-not-need-an-effect#adjusting-some-state-when-a-prop-changes for the pattern followed here.
There was a problem hiding this comment.
You can if it's called conditionally; it prevents extra render.
Refs:
- https://react.dev/reference/react/useState#storing-information-from-previous-renders
- https://react.dev/learn/you-might-not-need-an-effect#adjusting-some-state-when-a-prop-changes
- https://blog.isquaredsoftware.com/2020/05/blogged-answers-a-mostly-complete-guide-to-react-rendering-behavior/#setting-state-while-rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates the
activeTabIdlogic in theCategoryTabscomponent and sets the state during render instead of using the effect.Initially, I planned to fix the effect dependencies (
setActiveIdcan be omitted, and we could also removeactiveTabId), but I realized we could use a different pattern.Why?
React will re-render
CategoryTabsimmediately and not render its children or update the DOM, avoiding rendering a tab list with an undefined active tab ID.Details:
Testing Instructions
Testing Instructions for Keyboard
Same.
Screencast
CleanShot.2024-11-19.at.18.08.33.mp4