Block Editor: Fix regression for root appender logic #68994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Regression
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Feb 1, 2025
Comment on lines
+204
to
+208
| const hasSelectedRoot = !! ( | ||
| rootClientId && | ||
| selectedBlockClientId && | ||
| rootClientId === selectedBlockClientId | ||
| ); |
There was a problem hiding this comment.
The previous code relied on returned type semantics; this ensures that client IDs are checked for equality.
|
Size Change: +11 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in df72157. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13090066335
|
t-hamano
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Thanks for the quick fix!
This may not be something we need to fix in this PR, but I noticed that the inserter button doesn't appear when the "Show Template" is enabled. Maybe there's some logic we need to add.
- Hide the Paragraph block
- Open any post
- Disable "Show Template"
- ✅The inserter appears
- Enable "Show Template"
- 🤔 The inserter doesn't appear
9cdee087df71c6f9eefffeff7c66c660.mp4
|
Thanks for testing, @t-hamano! That's interesting, and I'll investigate separately. On the surface, it seems like a desired behavior. The Post Content becomes our root block; appender logic becomes similar to Group or any other container block. It's displayed when the root block is selected. |
Kallyan01
pushed a commit
to Kallyan01/gutenberg
that referenced
this pull request
Feb 24, 2025
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A follow-up to #68951.
PR fixes a regression when the root appender is incorrectly displayed.
After switching a method for retrieving
selectedBlockClientId, arootClientId === selectedBlockClientIdcondition became true when no blocks were selected. Why?The
getSelectedBlockClientIdselect returnsnullwith no block selection, androotClientIdisundefined, failing equality checks. NowselectedBlockClientIdalso returnsundefined, which introduces a regression.I've hardened the check to ensure equality is checked only for
clientIdstrings.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast