Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visibility of Social Icons block appender in dark themes #69006

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

dhruvikpatel18
Copy link
Contributor

@dhruvikpatel18 dhruvikpatel18 commented Feb 3, 2025

What?

Closes: #51799

This PR improves the visibility of the Social Icons block appender ([+] button) when used inside a Navigation block, especially on dark themes. The appender's icon is now styled to ensure it contrasts well with dark backgrounds.

Why?

The appender in the Social Icons block is currently hard to see on dark themes, as its color does not contrast well with the background. This PR addresses this issue by explicitly setting the appender's icon color to white and ensuring it has a consistent background color.

How?

  • Added CSS to target the svg element inside the .block-editor-button-block-appender.
  • Set the color of the svg to white for better visibility on dark themes.
  • Ensured the changes do not affect the appender's appearance in light themes or other contexts.

Testing Instructions

  1. Open the Gutenberg editor.
  2. Add a Navigation block.
  3. Insert a Social Icons block inside the Navigation block.
  4. Switch to a dark theme.
  5. Verify that the appender ([+] button) is clearly visible.
  6. Switch to a light theme and ensure the appender looks consistent.

Screenshots or screencast

Before Changes

BlockAppender.after.mov

After changes

BlockAppender.before.mov

@dhruvikpatel18 dhruvikpatel18 marked this pull request as ready for review February 3, 2025 10:24
Copy link

github-actions bot commented Feb 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhruvikpatel18 <[email protected]>
Co-authored-by: scruffian <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block [Block] Social Affects the Social Block - used to display Social Media accounts labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Social Affects the Social Block - used to display Social Media accounts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Social Icons in Navigation block
2 participants