Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance: Added show outline command #69015

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Enhance: Added show outline command #69015

wants to merge 1 commit into from
+67 −3

Conversation

Mayank-Tripathi32
Copy link
Contributor

@Mayank-Tripathi32 Mayank-Tripathi32 commented Feb 3, 2025 •
edited
Loading

Attempt to resolve #53191

What?

Added "Show document outline" command to open List View in outline tab.

Why?

How?

  • Added private API to manage List View tabs
  • Created new command to open List View with outline tab active
  • Reused existing List View functionality

Testing Instructions

  • Open editor
  • Press Cmd+k (Mac) or Ctrl+k (Windows)
  • Type "outline"
  • Select "Show document outline"
  • Verify List View opens in outline tab
  • Verify that command palette is closed
  • Verify outline remains visible

Testing Instructions for Keyboard

  • Press Cmd+k (Mac) or Ctrl+k (Windows)
  • Type "outline" using keyboard
  • Use arrow keys to navigate to "Show document outline"
  • Press Enter to activate
  • Verify focus moves to outline
  • Tab to navigate outline items

ScreenCast

Screen.Recording.2025-02-04.at.12.44.36.AM.mov

@Mayank-Tripathi32 Mayank-Tripathi32 marked this pull request as ready for review February 3, 2025 20:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mayank-Tripathi32 <[email protected]>
Co-authored-by: abhi3315 <[email protected]>
Co-authored-by: draganescu <[email protected]>
Co-authored-by: richtabor <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

yogeshbhutkar
yogeshbhutkar reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@yogeshbhutkar yogeshbhutkar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this PR tests well for me.

test.mov

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Package] Commands /packages/commands [Type] Command Palette labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogeshbhutkar yogeshbhutkar yogeshbhutkar left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
[Package] Commands /packages/commands [Type] Command Palette [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add command to view the document outline
3 participants
@Mayank-Tripathi32 @yogeshbhutkar @t-hamano