Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove empty space from figure tag and fix img tag alignment. #69267

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

coder-rancho
Copy link

What?

Closes #69255

Why?

After merging this PR, we'll be able to vertically align the image to the middle.

How?

  • Remove the hardcoded vertical-align: bottom.
  • Use line-height: 0 to remove empty space around <img> tag.

Testing Instructions

Screenshots or screencast

Before After
Image on the left is not vertically aligned with the text on the right. Image is perfectly aligned to the middle.
image image

Copy link

github-actions bot commented Feb 20, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: coder-rancho <[email protected]>
Co-authored-by: aialvi <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: hanneslsm <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Feb 20, 2025
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @coder-rancho! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image: hardcoded vertical alignment: bottom makes it impossible to correctly align images
2 participants