DataView Actions: Allow customizable modal size
through props
#69302
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #69294
This PR would allow the consumers to set up the
modal size
withinDataView actions
.Why?
The consumer implementation supports various modal behaviors but does not specify the
size
parameter, which the internalModal
component supports. Currently, the size is hardcoded tomedium
.How?
The type declarations for
ActionModal
have been updated, allowingaction.size
to be used as a prop for customization.Testing Instructions
npm run storybook:dev
).modalSize
prop here in the action with iddelete
:gutenberg/packages/dataviews/src/components/dataviews/stories/fixtures.tsx
Line 578 in 8898589
modal size
changes.Screencast
dataviews.mov