Template Part block: Guard against get_block_file_template returning null
#69309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Type] Bug
|
The "new" error message matches what the user sees in the editor: 
|
ockham
force-pushed
the
fix/template-part-block
branch
from
35821a7 to
1e47524
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flagging this for inclusion in WP 6.8 @Mamaduka @fabiankaegy 🙂 |
ockham
added a commit
that referenced
this pull request
Feb 25, 2025
…g `null` (#69309) Co-authored-by: ockham <[email protected]> Co-authored-by: paulopmt1 <[email protected]> Co-authored-by: josephscott <[email protected]>
|
I've cherry-picked ac34493 to the |
|
Thanks, @ockham! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a guard to ensure
$block_template->contentexists before assigning its value to a variable.Why?
The Template Part PHP code uses
get_block_file_template()to fetch information about the given template part from the corresponding theme's block template file. However, that function can returnnull, and the code currently guard against that when attempting to get the returned$block_templateobject's->contentfield.How?
See above.
By keeping
$contentset to its initialnull, a later check in the Template Part block code will issue a more user-friendly warning.Testing Instructions
<!-- wp:template-part {"slug":"post-meta"} /-->Screenshots or screencast