Skip to content
This repository has been archived by the owner on Jul 9, 2018. It is now read-only.

Add .editorconfig #4

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Add .editorconfig #4

merged 1 commit into from
Jun 28, 2017

Conversation

ntwb
Copy link
Member

@ntwb ntwb commented Jun 28, 2017

See also: WordPress/gutenberg#1067

The package.json exception remains per WordPress/gutenberg#1029 (comment)

"Granted this does make sense for package.json because npm will pretty much force you to use 2-space indentation."

Note: npm 5 fixes the package.json indentation issue but where not there yet

youknowriad
youknowriad approved these changes Jun 28, 2017
View reviewed changes
Copy link
Collaborator

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should make an exception for lerna.json too since it's a generated file.

@ntwb
Copy link
Member Author

ntwb commented Jun 28, 2017

Let's go with as it is now, next time lerna.json is changed we will find out :yolo:

@youknowriad youknowriad merged commit b0deb3c into WordPress:master Jun 28, 2017
@ntwb ntwb deleted the patch-2 branch June 28, 2017 10:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@youknowriad youknowriad youknowriad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntwb @youknowriad