Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styles for lists of "props"/"contributors" #363

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

coreymckrill
Copy link
Contributor

@coreymckrill coreymckrill commented Mar 17, 2022

Registers some block styles and adds related rules to the stylesheet to match the design for "Contributors" blocks. In some release posts (major releases), the [wpcredits] shortcode is used, which can't have the block styles applied to it, so there's a separate PR to add the correct classes to the container that it renders. For other release posts (minor releases), the list of props is usually generated via a script and pasted into a paragraph or code block. For these, the block style can be applied manually to be able to match the design.

Note that the design calls for the props block to be full width. It seemed to make more sense to just have the post author add the additional alignfull class to the block, rather than trying to match the same full width styles with another class name.

Fixes #355

To test

  1. Edit a release post in the dev environment sample data (5.7.1 is a good example) and try applying block styles to the paragraph containing the list of props.
  2. You'll also need to add alignfull as a custom class on the paragraph.
  3. It still won't quite match the design since the props are separate by commas rather than bullets (something that's addressed for the major releases in the other PR), but it'll be close.

Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@coreymckrill coreymckrill merged commit 89bb2a1 into trunk Mar 28, 2022
@coreymckrill coreymckrill deleted the fix/355/contributors-styles branch March 28, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Contributors" styles
2 participants