Ci/tests #9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| name: CI | ||
|
|
||
| # Concurrency group that uses the workflow name and PR number if available | ||
| # or commit SHA as a fallback. If a new build is triggered under that | ||
| # concurrency group while a previous build is running it will be canceled. | ||
| # Repeated pushes to a PR will cancel all previous builds, while multiple | ||
| # merges to main will not cancel. | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }} | ||
| cancel-in-progress: true | ||
|
|
||
| env: | ||
| FORCE_COLOR: "1" # Make tools pretty | ||
|
|
||
| permissions: {} | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| # Run our test suite on various combinations of OS & Python versions | ||
| run-pytest: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.10", "3.11", "3.12"] | ||
| # test fail on windows for now | ||
| os: [ubuntu-22.04, ubuntu-latest, macos-latest] | ||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| - name: Install poetry | ||
| uses: abatilo/actions-poetry@v3 | ||
| - name: Setup poetry | ||
| run: | | ||
| poetry config virtualenvs.create true --local | ||
| poetry config virtualenvs.in-project true --local | ||
| - uses: actions/cache@v4 | ||
| name: Define a cache for the virtual environment based on the dependencies file | ||
| with: | ||
| path: | | ||
| ./.venv | ||
| poetry.lock | ||
| key: venv-${{ hashFiles('pyproject.toml') }}-${{ matrix.python-version }}-${{ matrix.os }} | ||
| - name: Install the project dependencies | ||
| run: poetry install --with test | ||
| - name: Run the test | ||
| run: | | ||
| poetry run coverage run -m pytest | ||
| poetry run coverage xml | ||
| - name: Upload Coverage to Codecov | ||
| if: matrix.python-version == '3.11' && matrix.os == 'ubuntu-latest' | ||
| uses: codecov/codecov-action@v4 | ||
| with: | ||
| fail_ci_if_error: true | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
|
|
||
| build-site: | ||
| name: "build docs" | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: "Checkout repository 🛎" | ||
| uses: actions/checkout@v4 | ||
| - name: Install poetry | ||
| uses: abatilo/actions-poetry@v3 | ||
| - name: "Install pandoc 📝" | ||
| uses: r-lib/actions/setup-pandoc@v2 | ||
| with: | ||
| pandoc-version: "latest" | ||
| - name: Setup poetry | ||
| run: | | ||
| poetry config virtualenvs.create true --local | ||
| poetry config virtualenvs.in-project true --local | ||
| - uses: actions/cache@v4 | ||
| name: Define a cache for the virtual environment based on the dependencies lock file | ||
| with: | ||
| path: | | ||
| ./.venv | ||
| poetry.lock | ||
| key: venv-${{ hashFiles('pyproject.toml') }} | ||
| - name: Install the project dependencies | ||
| run: poetry install --with test | ||
| - name: "Build docs and check for warnings 📖" | ||
| shell: bash | ||
| run: | | ||
| poetry run sphinx-build docs docs/_build -W | ||
|
|
||
| run-pyright: | ||
|
There was a problem hiding this comment. why not run pre-commit altogether which will include pyright but also black, ruff, etc ? There was a problem hiding this comment. pre-commit is already run with pre-commit.ci. You can see actually that it's run at every commit in this PR, when you show all the checks. And pre-commit no longer runs pyright, because it's a job that needs an installed environment, contrary to other linters, hence the dedicated job here There was a problem hiding this comment. Here's what I see in the checks 🤔 I'm I missing something ? There was a problem hiding this comment. 
You can scroll the list of tests inside the mbedded window ;)
There was a problem hiding this comment. Note that pre-commit, codecov and RTD are not github actions but webhook, that's why they only appear on the test breakdown insidd the PR but not in the Actions tab |
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Install poetry | ||
| uses: abatilo/actions-poetry@v3 | ||
| - name: Setup poetry | ||
| run: | | ||
| poetry config virtualenvs.create true --local | ||
| poetry config virtualenvs.in-project true --local | ||
| - uses: actions/cache@v4 | ||
| name: Define a cache for the virtual environment based on the dependencies file | ||
| with: | ||
| path: | | ||
| ./.venv | ||
| poetry.lock | ||
| key: venv-${{ hashFiles('pyproject.toml') }} | ||
| - name: Install the project dependencies | ||
| run: poetry install --with test | ||
| - run: echo "$PWD/.venv/bin" >> $GITHUB_PATH | ||
| - uses: jakebailey/pyright-action@v2 | ||
| name: Run pyright | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -532,6 +532,7 @@ def test_from_files(): | |
| dataset.check() | ||
|
|
||
|
|
||
| @pytest.mark.xdist_group(name="fiftyone-group") | ||
|
There was a problem hiding this comment. Out of curiosity, why did you group all fiftyone tests? There was a problem hiding this comment. This is done to ensure they are run in the same process. Now, you can launch the tests locally with multiple proceses, thanks to pytest xdist : https://pytest-xdist.readthedocs.io/en/stable/ But the tests involving fiftyone must be run sequentially becasue there can be only one mongodb runnin at the same time. |
||
| def test_to_fiftyone(): | ||
| val_dataset = from_coco( | ||
| coco_json=DATA / "coco_dataset/annotations_valid.json", | ||
|
|
@@ -563,6 +564,7 @@ def test_to_fiftyone(): | |
| fo.delete_dataset("dataset") | ||
|
|
||
|
|
||
| @pytest.mark.xdist_group(name="fiftyone-group") | ||
| def test_to_fiftyone_empty(): | ||
| val_dataset = from_coco( | ||
| coco_json=DATA / "coco_dataset/annotations_valid.json", | ||
|
|
@@ -578,6 +580,7 @@ def test_to_fiftyone_empty(): | |
| fo.delete_dataset("dataset") | ||
|
|
||
|
|
||
| @pytest.mark.xdist_group(name="fiftyone-group") | ||
| def test_to_fiftyone_debooleanize(): | ||
| dataset = from_caipy_generic( | ||
| annotations_folder=DATA / "caipy_dataset" / "tags" / "default_schema", | ||
|
|
@@ -596,6 +599,7 @@ def test_to_fiftyone_debooleanize(): | |
| fo.delete_dataset("dataset") | ||
|
|
||
|
|
||
| @pytest.mark.xdist_group(name="fiftyone-group") | ||
| def test_to_fiftyone_keypoint(): | ||
| dataset = from_coco_keypoints( | ||
| coco_json=DATA / "coco_dataset/annotations_keypoints.json", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we run this stage as a safetly measure to detect warnings in the doc (that are not detected by RTD's builds) and the publish of the doc is handeled by RTD right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes