Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YS-375] refactor: 자동 스캔 문제를 방지하기 위한 domain 모듈 패키지 구조 리팩터링 #125

Merged
merged 5 commits into from
Mar 2, 2025

Conversation

chock-cho
Copy link
Member

@chock-cho chock-cho commented Mar 2, 2025

💡 작업 내용

디스코드 서버 채널에서 논의한 안건인 확장성을 위해, 도메인 모듈의 패키지 구조를 개선하였습니다.

  • domain 모듈 패키지 구조를 com.dobby로 통일
  • 자동 스캔 문제 해결을 위한 패키지 경로 수정
  • JPQL 카운트 쿼리 로직 수정

✅ 셀프 체크리스트

  • PR 제목을 형식에 맞게 작성했나요?
  • 브랜치 전략에 맞는 브랜치에 PR을 올리고 있나요?
  • 테스트는 잘 통과했나요?
  • 빌드에 성공했나요?
  • 본인을 assign 해주세요.
  • 해당 PR에 맞는 label을 붙여주세요.

🙋🏻‍ 확인해주세요

  • 도메인 모듈 패키지 구조 com.dobby.domaincom.dobby로 변경
  • 부트스트랩 모듈 분리 시 자동 스캔 문제 방지
  • 확장성을 고려해 사전 정리 진행
  • 레퍼런스 기술 블로그 참고하여 작업을 진행했습니다 ☺️

🔗 Jira 티켓


https://yappsocks.atlassian.net/browse/YS-375

@chock-cho chock-cho added 🐛 BUG 버그 ⚙️ CHORE config, workflow.yaml ♻️ REFACTORING 리팩토링 ✅ TEST 테스트 코드 추가 labels Mar 2, 2025
@chock-cho chock-cho self-assigned this Mar 2, 2025
Copy link

coderabbitai bot commented Mar 2, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

79 files out of 186 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@chock-cho chock-cho requested a review from Ji-soo708 March 2, 2025 12:41
Copy link
Member

@Ji-soo708 Ji-soo708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 수고하셨습니다~

@Ji-soo708 Ji-soo708 merged commit ec818bd into dev Mar 2, 2025
3 checks passed
@Ji-soo708 Ji-soo708 deleted the refact/YS-375 branch March 2, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 BUG 버그 ⚙️ CHORE config, workflow.yaml ♻️ REFACTORING 리팩토링 ✅ TEST 테스트 코드 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants