Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only disallow a pair if they matched earlier for the same subscription #94

Merged
merged 1 commit into from
Jul 28, 2017
Merged

Only disallow a pair if they matched earlier for the same subscription #94

merged 1 commit into from
Jul 28, 2017

Conversation

harshk360
Copy link
Contributor

@harshk360 harshk360 commented Jul 28, 2017 •
edited
Loading

  • Only disallow a pair if they matched earlier for the same subscription
  • Added a test for the above (test_get_previous_meetings_multi_subscription)
  • Further refactor to abstract out a single generate_meetings method which can accept an optional parameter for the group size.

@harshk360 harshk360 force-pushed the fix/subscription_specific_check branch from d966dab to 47ce976 Compare July 28, 2017 00:31
@kentwills kentwills merged commit 23d61de into Yelp:master Jul 28, 2017
jeffrey-xiao added a commit to jeffrey-xiao/beans that referenced this pull request Jul 28, 2017
@jeffrey-xiao
Merge branch 'master' of https://github.com/Yelp/beans
b21b893 
* 'master' of https://github.com/Yelp/beans:
  Save multiple participants for a meeting into db + refactoring (Yelp#100)
  method to get a dictionary of {user_pair:previous meeting count} (Yelp#98)
  downgrade react-router to v3.0.0 and a11y to v5.1.1 (Yelp#99)
  Revert eslint-plugin-jsx-a11y version to 5.1.1 to deal webpack errors (Yelp#97)
  Only disallow a pair if they matched earlier for the same subscription (Yelp#94)
  Devme (Yelp#92)
  Import PropTypes from prop-types package instead of react
  Created new module for matching. Renamed match.py to pair_match.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentwills kentwills kentwills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshk360 @kentwills