operator= checks this equality before moving (#5265)

Z3Prover · May 12, 2021 · f942c3d · f942c3d
1 parent 7869cdb
commit f942c3d
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/api/c++/z3++.h b/src/api/c++/z3++.h
@@ -511,9 +511,11 @@ namespace z3 {
             return *this;
         }
         ast & operator=(ast && s) noexcept {
-            object::operator=(std::forward<object>(s));
-            m_ast = s.m_ast;
-            s.m_ast = nullptr;
+            if (this != &s) {
+                object::operator=(std::forward<object>(s));
+                m_ast = s.m_ast;
+                s.m_ast = nullptr;
+            }
             return *this;
         }
         Z3_ast_kind kind() const { Z3_ast_kind r = Z3_get_ast_kind(ctx(), m_ast); check_error(); return r; }