-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: When adding options, prefix with "Z3_" #2709
Comments
could you add pull request? |
NikolajBjorner
added a commit
that referenced
this issue
Nov 19, 2019
…(tiny part of #2709) Signed-off-by: Nikolaj Bjorner <[email protected]>
NikolajBjorner
added a commit
that referenced
this issue
Nov 19, 2019
Signed-off-by: Nikolaj Bjorner <[email protected]>
NikolajBjorner
added a commit
that referenced
this issue
Nov 19, 2019
Signed-off-by: Nikolaj Bjorner <[email protected]>
NikolajBjorner
added a commit
that referenced
this issue
Nov 19, 2019
Signed-off-by: Nikolaj Bjorner <[email protected]>
NikolajBjorner
added a commit
that referenced
this issue
Nov 19, 2019
Signed-off-by: Nikolaj Bjorner <[email protected]>
NikolajBjorner
added a commit
that referenced
this issue
Nov 19, 2019
Signed-off-by: Nikolaj Bjorner <[email protected]>
suggestion seems to make sense, but implementing it will almost for sure break things. |
NikolajBjorner
added a commit
that referenced
this issue
Nov 19, 2019
Signed-off-by: Nikolaj Bjorner <[email protected]>
NikolajBjorner
added a commit
that referenced
this issue
Nov 19, 2019
Signed-off-by: Nikolaj Bjorner <[email protected]>
NikolajBjorner
added a commit
that referenced
this issue
Nov 19, 2019
Signed-off-by: Nikolaj Bjorner <[email protected]>
NikolajBjorner
added a commit
that referenced
this issue
Nov 19, 2019
Signed-off-by: Nikolaj Bjorner <[email protected]>
These changes are great Nikolaj - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you use library like this as a submodule in another project, it is very useful to have its options prefixed by the project name. Otherwise you end up with options sprinkled throughout the cmake interface and it's not obvious which project they are for.
e.g.
API_LOG_SYNC
,BUILD_DOTNET_BINDINGS
,ENABLE_TRACING_FOR_NON_DEBUG
,INCLUDE_GIT_DESCRIBE
, etc..This gets worse as you include more external libraries in your project. You can also end up with option name collisions.
As a bonus when adding a prefix, the graphical interface to cmake will group options together under the first "word" (up to the first ""). So if they are all prefixed by "Z3" they get grouped and it's much easier to manage.
The text was updated successfully, but these errors were encountered: