This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Default tree refactoring to use file manager of package stream #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruna Tavares <[email protected]>
Signed-off-by: Bruna Tavares <[email protected]>
Signed-off-by: Bruna Tavares <[email protected]>
Signed-off-by: Bruna Tavares <[email protected]>
Signed-off-by: Bruna Tavares <[email protected]>
…ent/added-tests-to-default-tree Signed-off-by: Bruna Tavares <[email protected]>
Signed-off-by: Bruna Tavares <[email protected]>
Signed-off-by: Bruna Tavares <[email protected]>
Signed-off-by: Bruna Tavares <[email protected]>
Signed-off-by: Bruna Tavares <[email protected]>
…ent/default-tree-refactoring Signed-off-by: Bruna Tavares <[email protected]>
Signed-off-by: Bruna Tavares <[email protected]>
Signed-off-by: Bruna Tavares <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
==========================================
+ Coverage 80.06% 80.38% +0.31%
==========================================
Files 98 98
Lines 3196 3196
==========================================
+ Hits 2559 2569 +10
+ Misses 448 443 -5
+ Partials 189 184 -5
Continue to review full report at Codecov.
|
brunasilvazup
changed the title
brunasilvazup
added
🔨 improvement
victor-schumacher
previously approved these changes
Oct 1, 2020
Signed-off-by: Bruna Tavares <[email protected]>
victor-schumacher
approved these changes
Oct 2, 2020
|
🥇 |
lucasdittrichzup
approved these changes
Oct 2, 2020
|
🚀 |
|
/merge qa |
|
👌 Merged branch improvement/default-tree-refactoring into qa |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
In this PR we exchange the use of
io/ioutiland/fileutiltoFileReadExisterin all functions ofdefault_tree.gofile.- How to verify it
Check the file
default tree.goto see the difference and in the tests of the related file check the use of interface.- Description for the changelog
Default tree refactoring to use file manager of package stream