Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

stable version was not updating when generate release #595

Conversation

victorschumacherzup
Copy link
Contributor

- Description
Stable version URL was not increasing when we make a release
After some investigation we found this error on delivery step:

/bin/sh: 1: Syntax error: Unterminated quoted string

- How to verify it

Run release pipeline

- Description for the changelog

Fix release regex

Signed-off-by: victor-schumacher <[email protected]>
Signed-off-by: victor-schumacher <[email protected]>
@victorschumacherzup victorschumacherzup force-pushed the fix/increaseStableVersion branch from 42ec734 to 4f9338f Compare October 6, 2020 14:38
@victorschumacherzup victorschumacherzup changed the title change regex stable version was not updating when generate release Oct 6, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #595 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
- Coverage   79.94%   79.93%   -0.02%     
==========================================
  Files          98       98              
  Lines        3241     3229      -12     
==========================================
- Hits         2591     2581      -10     
+ Misses        465      464       -1     
+ Partials      185      184       -1     
Impacted Files Coverage Δ
pkg/formula/tree/default_tree.go 100.00% <0.00%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd807b7...4f9338f. Read the comment docs.

@lucasdittrichzup lucasdittrichzup added 🪲 bug Report a bug encountered while operating Ritchie ✔️ ready-for-review ready for review labels Oct 6, 2020
@lucasdittrichzup lucasdittrichzup added this to the 2.2.0 milestone Oct 6, 2020
@victorschumacherzup victorschumacherzup merged commit 9cf8c87 into ZupIT:master Oct 6, 2020
@lucasdittrichzup
Copy link
Contributor

/merge qa

@ritchie-bot
Copy link
Contributor

ritchie-bot bot commented Oct 6, 2020

👌 Merged branch fix/increaseStableVersion into qa

@victorschumacherzup victorschumacherzup deleted the fix/increaseStableVersion branch October 6, 2020 18:51
brunonmelo pushed a commit to brunonmelo/ritchie-cli that referenced this pull request Nov 12, 2020
* change regex

Signed-off-by: victor-schumacher <[email protected]>
Signed-off-by: Bruno N. Melo <[email protected]>
brunonmelo pushed a commit to brunonmelo/ritchie-cli that referenced this pull request Nov 12, 2020
* change regex

Signed-off-by: victor-schumacher <[email protected]>
Signed-off-by: Bruno N. Melo <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🪲 bug Report a bug encountered while operating Ritchie ✔️ ready-for-review ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The stable.txt doesn't increase version when generating a new release
5 participants