This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Remove formula tmp dir #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kadu Artur Prussek <[email protected]>
Signed-off-by: Kadu Artur Prussek <[email protected]>
kaduartur
added
🔨 improvement
Signed-off-by: Kadu Artur Prussek <[email protected]>
Signed-off-by: Kadu Artur Prussek <[email protected]>
Signed-off-by: Kadu Artur Prussek <[email protected]>
kaduartur
requested review from
brunasilvazup,
henriquemoraeszup,
lucasdittrichzup and
rodrigomedeirosf
as code owners
kaduartur
added
✔️ ready-for-review
lucasdittrichzup
previously approved these changes
Mar 2, 2021
|
can you make an issue and link to your project? |
| @@ -166,20 +158,6 @@ func (pr PreRunManager) loadConfig(formulaPath string, def formula.Definition) ( | |||
| return formulaConfig, nil | |||
| } | |||
|
|
|||
| func (pr PreRunManager) createWorkDir(home, formulaPath string, def formula.Definition) (string, error) { | |||
| tDir := def.TmpWorkDirPath(home) | |||
There was a problem hiding this comment.
I think you need to remove this method from pkg/formula
Comment on lines
177
to
181
| if got != nil || tt.out.err != nil { | ||
| assert.EqualError(t, tt.out.err, got.Error()) | ||
| } | ||
|
|
||
| _ = os.Chdir(pwd) |
There was a problem hiding this comment.
Can we test for file creation on the correct dir? This is the purpose of this PR correct?
There was a problem hiding this comment.
Which file? this PR just stops copying the /bin folder of a formula to a tmp folder.
Comment on lines
151
to
155
| local := NewRunner(in.inputResolver, in.preRun, in.fileManager, in.env, homeDir) | ||
| got := local.Run(in.def, api.Prompt, false, nil) | ||
|
|
||
| if tt.out.err != nil && got != nil && tt.out.err.Error() != got.Error() { | ||
| t.Errorf("Run(%s) got %v, want %v", tt.name, got, tt.out.err) | ||
| if tt.want != nil || got != nil { | ||
| assert.EqualError(t, got, tt.want.Error()) |
henriquemoraeszup
added
waiting reply
henriquemoraeszup
suggested changes
Mar 2, 2021
4 tasks
Signed-off-by: Kadu Artur Prussek <[email protected]>
kaduartur
added
✔️ ready-for-review
victor-schumacher
previously approved these changes
Mar 3, 2021
brunasilvazup
previously approved these changes
Mar 3, 2021
|
/merge qa |
|
It would be interesting to simulate an execution that creates a file and checks its creation on the correct folder |
Signed-off-by: Kadu Artur Prussek <[email protected]>
kaduartur
dismissed stale reviews from brunasilvazup and victor-schumacher
via
2259b48
Signed-off-by: Kadu Artur Prussek <[email protected]>
I fixed this bug in this commit |
Signed-off-by: Kadu Artur Prussek <[email protected]>
kaduartur
added
✔️ ready-for-review
Comment on lines
179
to
180
| fileCreted := filepath.Join(formulaPath, "test.txt") | ||
| assert.FileExists(t, fileCreted) |
| @@ -153,86 +153,6 @@ func TestPreRun(t *testing.T) { | |||
| err: errors.New("invalid character 'e' looking for beginning of value"), | |||
| }, | |||
| }, | |||
| { | |||
| name: "create work dir error", | |||
|
/merge qa |
|
🔥 Merge Conflict |
|
/merge qa |
|
👌 Merged branch performance/remove_tmp_dir into qa |
Signed-off-by: Kadu Artur Prussek <[email protected]>
brunasilvazup
previously approved these changes
Mar 8, 2021
|
The implementation is breaking on Windows, just create a formula and run to see |
Signed-off-by: Kadu Artur Prussek <[email protected]>
Signed-off-by: Kadu Artur Prussek <[email protected]>
Signed-off-by: Kadu Artur Prussek <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #875 +/- ##
==========================================
- Coverage 85.31% 84.64% -0.68%
==========================================
Files 113 112 -1
Lines 4039 4018 -21
==========================================
- Hits 3446 3401 -45
- Misses 413 433 +20
- Partials 180 184 +4
Continue to review full report at Codecov.
|
|
/merge qa |
|
👌 Merged branch performance/remove_tmp_dir into qa |
henriquemoraeszup
approved these changes
Mar 10, 2021
kaduartur
added a commit
that referenced
this pull request
Mar 15, 2021
This reverts commit 0ca725c.
kaduartur
added a commit
that referenced
this pull request
Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The need to copy the formula to a temporary folder has been removed, thus reducing the necessary IO when executing a formula.
How to verify it
This improvement should not change the functionality of the rit.
Changelog
Performance - remove tmp dir to formulas