-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to find source repo for a package #137
Conversation
68c8882
to
5b04be0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TG1999 Thanks for the PR! I've left some comments regarding the use of list indexes and readability.
3633209
to
d2139dc
Compare
3811722
to
43aa074
Compare
cad569d
to
0d7ed31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TG1999 I've left some comments for you
packagedb/find_source_repo.py
Outdated
source_purls = list(convert_repo_urls_to_purls(repo_urls)) | ||
if not source_purls: | ||
return | ||
source_purls = set(list(source_purls)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you trying to dedup source_purls
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
0d4aad5
to
8e40335
Compare
Signed-off-by: Tushar Goel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TG1999 Thanks for the changes! I have some small things for you to revise, but your code looks alright and I will try out the source repo package creation tomorrow.
Signed-off-by: Tushar Goel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TG1999 LGTM!
No description provided.