Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to find source repo for a package #137

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Jul 3, 2023

No description provided.

Copy link
Member

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TG1999 Thanks for the PR! I've left some comments regarding the use of list indexes and readability.

@TG1999 TG1999 force-pushed the find_source_repo branch 2 times, most recently from 3633209 to d2139dc Compare July 6, 2023 10:41
@TG1999 TG1999 requested a review from JonoYang July 6, 2023 10:44
@TG1999 TG1999 force-pushed the find_source_repo branch 3 times, most recently from 3811722 to 43aa074 Compare July 10, 2023 10:57
@TG1999 TG1999 force-pushed the find_source_repo branch 9 times, most recently from cad569d to 0d7ed31 Compare July 20, 2023 16:57
Copy link
Member

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TG1999 I've left some comments for you

source_purls = list(convert_repo_urls_to_purls(repo_urls))
if not source_purls:
return
source_purls = set(list(source_purls))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you trying to dedup source_purls?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@TG1999 TG1999 force-pushed the find_source_repo branch 6 times, most recently from 0d4aad5 to 8e40335 Compare July 26, 2023 06:05
@TG1999 TG1999 force-pushed the find_source_repo branch from 8e40335 to 1d59324 Compare July 26, 2023 06:18
Copy link
Member

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TG1999 Thanks for the changes! I have some small things for you to revise, but your code looks alright and I will try out the source repo package creation tomorrow.

Signed-off-by: Tushar Goel <[email protected]>
@JonoYang JonoYang self-requested a review July 27, 2023 23:11
Copy link
Member

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TG1999 LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants