Add vers support in index_packages endpoint

[keshav-space]

• resolves Support vers in index_packages endpoint #155

[pombredanne]

Thanks! this is looking good, but I would prefer we find a way to avoid code copy from VulnerableCode. How could we share this code?
And if we go ahead and merge this, what's the plan to remove this duplication?

[keshav-space]

How could we share this code?
And if we go ahead and merge this, what's the plan to remove this duplication?

As discussed earlier, we will move this piece of code to the fetchcode.
Also, IMO this would right time to do some refactoring like:

• Using PURLs for all the fetch methods as described here Use PURL in VersionAPIs vulnerablecode#1145
• Result should be the proper univers Version rather than the generic PackageVersion.

[tdruez]

This PR is a blocker for aboutcode-org/scancode.io#836 (comment)
@keshav-space @pombredanne what's the status here?

[keshav-space]

This PR is a blocker for nexB/scancode.io#836 (comment) @keshav-space @pombredanne what's the status here?

@tdruez waiting for review from @pombredanne and @JonoYang

[JonoYang]

@keshav-space Thanks for the PR! I've left some comments for your consideration.

[JonoYang]

I think its more Pythonic to sort the list of downloads by the upload time, then popping the latest download entry from the list.

Suggested change

	for download in downloads:
	# Sort `downloads` from earliest "upload_time_iso_8601" to latest
	downloads = downloads.sort(key=lambda x: x["upload_time_iso_8601"])
	# Pop the latest download entry from `downloads`
	latest_download = downloads.pop()
	latest_date = latest_download.get("upload_time_iso_8601")
	if latest_date:
	latest_date = dateparser.parse(latest_date)
	return latest_date

[keshav-space]

@JonoYang I was trying to keep package_managers code untouched and refactor it while migrating to fetchcode.

[JonoYang]

@keshav-space Ah, I see.

[pombredanne]

Thanks... some nits for your consideration.

[JonoYang]

@keshav-space LGTM!

@pombredanne Is there anything else you see that needs to be updated?

[JonoYang]

@keshav-space

Merging, thanks for the contribution!