Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Github Mapper route #370

Merged
merged 10 commits into from
Apr 4, 2024
Merged

Conversation

404-geek
Copy link
Contributor

@404-geek 404-geek commented Apr 4, 2024

The github mapper function (minecode/mappers/github.py) is having issues where the github urls fetched in run_visit command are not able to parse and are failing to get added into DB.

This is because of the improper router regex in the mapper file.

@map_router.route('https://api.github.com/repos/[\w\-\.]/[\w\-\.]')

The below regex url is able to parse the urls successfully

@map_router.route('https://api\.github\.com/repos/([^/]+)/([^/]+)')

@JonoYang JonoYang merged commit 7134dcf into aboutcode-org:main Apr 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants