Performance tuning: #112
Merged
Performance tuning: #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 6, 2022 19:07
First make a list of target hashes excluding duplicates Calculate hashes and compare with all target hashes
|
Thank you so much for this improvement. Much appreciated. |
|
Woah, that was a pretty fast merge :D But I will probably re-write it with a generator. Next pull request incoming ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tuned the performance a little bit. In the original it calculates all the hashes for each line in each file.
Therefore calculating the same hash over and over again.
I collect the searched hashes first, excluding duplicate entries. Then I calculate the hashes once and check if there is a match.
Also I extended the number-range from 7 to 10, because german numbers are longer