Skip to content
This repository has been archived by the owner on Nov 19, 2020. It is now read-only.

Unsafe code exposed in the public API #805

Closed
CatchemAL opened this issue Aug 23, 2017 · 2 comments · Fixed by #806
Closed

Unsafe code exposed in the public API #805

CatchemAL opened this issue Aug 23, 2017 · 2 comments · Fixed by #806
Milestone

Comments

@CatchemAL
Copy link
Collaborator

Some of the methods added in GH-752 expose the unsafe keyword in the public API. That is, the signature is public static unsafe. I am really very sorry about this :( - I did not realise this and it will only affect a small number of users - but it will cause a problem for users who cannot run code in an unsafe environment (for instance, Silverlight users will be affected). The fix is to move the unsafe code inside the method calls.

@cesarsouza
Copy link
Member

Hi @AlexJCross,

Please do not worry. I will be including it in a 3.7.1 (bugfix) release quite soon.

Thanks a lot for the pull request (and if you would like and I haven't asked you before, please let me know of a name and contact e-mail that I can add you to the list of contributors of the framework!)

Regards,
Cesar

@CatchemAL
Copy link
Collaborator Author

Hi @cesarsouza,

Ok thanks v much for the message. I hope the hit fix isn't too much trouble.

Sure - by all means do!

Alex Cross
[email protected]

cesarsouza added a commit that referenced this issue Aug 25, 2017
GH-805: Fixing issue with unsafe keyword being exposed in the public API
@cesarsouza cesarsouza added this to the 3.8 milestone Oct 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants