Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Add list-missing command #22

Merged
merged 1 commit into from
Mar 29, 2022
Merged

[IMP] Add list-missing command #22

merged 1 commit into from
Mar 29, 2022

Conversation

hparfr
Copy link
Contributor

@hparfr hparfr commented Feb 24, 2022

List missing modules in a new command

Because manifestoo tree | grep not installed | sed .... is not handy

@hparfr
Copy link
Contributor Author

hparfr commented Feb 24, 2022

By the way, how do we run tests in this project ? :-)

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #22 (92f238b) into main (018cffb) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   94.22%   94.26%   +0.04%     
==========================================
  Files          21       21              
  Lines         658      663       +5     
  Branches      126      126              
==========================================
+ Hits          620      625       +5     
  Misses         21       21              
  Partials       17       17              
Impacted Files Coverage Δ
src/manifestoo/main.py 77.98% <100.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 018cffb...92f238b. Read the comment docs.

@sbidoul
Copy link
Member

sbidoul commented Feb 25, 2022

List missing modules in a new command

Why not :)

By the way, how do we run tests in this project ? :-)

I guess I'll need to document that. In the meantime:

$ pipx install tox
$ tox -e py38

or, in an active virtualenv with a recent pip

$ pip install -e .[test]
$ pytest

Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you update documentation ?

@sbidoul
Copy link
Member

sbidoul commented Mar 28, 2022

Looks good. Can you squash and add a news/22.feature with a short changelog entry ?

@hparfr
Copy link
Contributor Author

hparfr commented Mar 28, 2022

Looks good. Can you squash and add a news/22.feature with a short changelog entry ?

Done

@sbidoul
Copy link
Member

sbidoul commented Mar 28, 2022

Hm, 2 pre-commit failures:
1/ black crashing, probably due to click 8.1 - I upgraded it, please rebase
2/ a missing new line in the newsfragment

@sbidoul sbidoul merged commit eba0c74 into acsone:main Mar 29, 2022
@hparfr
Copy link
Contributor Author

hparfr commented Mar 29, 2022

Thanks @sbidoul

@hparfr hparfr deleted the list-missing branch March 29, 2022 14:28
@sbidoul
Copy link
Member

sbidoul commented Mar 29, 2022

Thanks to you for the contrib, @hparfr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants