Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if addon has an __init__.py #25

Merged
merged 3 commits into from
May 10, 2022
Merged

Check if addon has an __init__.py #25

merged 3 commits into from
May 10, 2022

Conversation

b-enoit-be
Copy link
Contributor

@b-enoit-be b-enoit-be commented May 3, 2022

Fix #15

Because creating a test module is not as trivial as it was before (it needs a valid manifest and an init file), I created a fixture to create modules for the test of Addon.

A step further would be to also refactor test/common.py:populate_addons_dir to be a fixture too.

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2022

Codecov Report

Merging #25 (3930786) into main (eba0c74) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   94.26%   94.30%   +0.03%     
==========================================
  Files          21       21              
  Lines         663      667       +4     
  Branches      126      128       +2     
==========================================
+ Hits          625      629       +4     
  Misses         21       21              
  Partials       17       17              
Impacted Files Coverage Δ
src/manifestoo/addon.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba0c74...3930786. Read the comment docs.

Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contrib.

Could you add a file named news/25.feature with a short changelog entry in reStructuredText format (or plain text) ?

@sbidoul sbidoul merged commit 5dc21b8 into acsone:main May 10, 2022
@sbidoul
Copy link
Member

sbidoul commented May 10, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check presence of __init__.py in addition to manifests
3 participants