Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI with Ruby 3.4, fix Rails Logger constant resolution issue #328

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update CI with Ruby 3.4, fix Rails Logger constant resolution issue #328

wants to merge 2 commits into from

Conversation

flavorjones
Copy link
Collaborator

@flavorjones flavorjones commented Jan 22, 2025 •
edited
Loading

  1. Fix missing Logger constant because the latest concurrent-ruby dropped logger as a dependency, this broke Rails's dependencies.
  2. Add Ruby 3.4 to the CI matrix (but exclude Rails 6.0 and 7.1 because of unbundled gem errors with bigdecimal, base64, etc.).

@flavorjones
ci: fix missing Logger constant
759d53b 
because the latest concurrent-ruby dropped logger as a dependency,
this broke Rails's dependencies. See
rails/rails#54264 for more details.
@flavorjones
ci: add Ruby 3.4 to the matrix
15bac4e 
Don't run 6.1 or 7.0 with Ruby 3.4 (some missing Gems due to moving
them out of the bundled set), and handle the 3.4 exception message
quoting changes.
@flavorjones flavorjones force-pushed the flavorjones-fix-ci-logger branch from 57ca3ee to 15bac4e Compare January 22, 2025 15:51
@flavorjones flavorjones requested a review from kbrock January 22, 2025 15:52
@flavorjones
Copy link
Collaborator Author

@kbrock Can you take a look and merge this when you get a second?

@flavorjones
Copy link
Collaborator Author

@kbrock bumping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbrock kbrock Awaiting requested review from kbrock

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flavorjones