You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The BtnLabeled component is the most used component in activist – which is getting to be a problem. The assumption that one component should be holding the logic for almost all buttons on the platform is making it very difficult to add in new functionality. Specifically the need for a dropdown button in #473 raises the question of whether this should be included in the current component, with the breaks that this was causing indicating that these changes are now necessary.
The new implementation will:
Save common props into TypeScript files
Split buttons based on functionality
Actions like share, support, etc
Routes that are either internal or external
Styles should also be extracted into commonly shared places in the code base
Contribution
I'm working on this now!
The text was updated successfully, but these errors were encountered:
Terms
Description
The
BtnLabeled
component is the most used component in activist – which is getting to be a problem. The assumption that one component should be holding the logic for almost all buttons on the platform is making it very difficult to add in new functionality. Specifically the need for a dropdown button in #473 raises the question of whether this should be included in the current component, with the breaks that this was causing indicating that these changes are now necessary.The new implementation will:
Contribution
I'm working on this now!
The text was updated successfully, but these errors were encountered: