Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split BtnLabeled into separate components #642

Closed
2 tasks done
andrewtavis opened this issue Jan 5, 2024 · 1 comment
Closed
2 tasks done

Split BtnLabeled into separate components #642

andrewtavis opened this issue Jan 5, 2024 · 1 comment
Assignees
Labels
-priority- High priority feature New feature or request

Comments

@andrewtavis
Copy link
Member

Terms

Description

The BtnLabeled component is the most used component in activist – which is getting to be a problem. The assumption that one component should be holding the logic for almost all buttons on the platform is making it very difficult to add in new functionality. Specifically the need for a dropdown button in #473 raises the question of whether this should be included in the current component, with the breaks that this was causing indicating that these changes are now necessary.

The new implementation will:

  • Save common props into TypeScript files
  • Split buttons based on functionality
    • Actions like share, support, etc
    • Routes that are either internal or external
  • Styles should also be extracted into commonly shared places in the code base

Contribution

I'm working on this now!

@andrewtavis
Copy link
Member Author

The component was split in 6e637a9 - so all done 😊

@github-project-automation github-project-automation bot moved this from In Progress to Done in activist Board Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-priority- High priority feature New feature or request
Projects
Archived in project
Development

No branches or pull requests

1 participant