Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor search result components to propogate to CardSearchResult #851

Closed
2 tasks done
andrewtavis opened this issue Apr 29, 2024 · 2 comments
Closed
2 tasks done
Assignees
Labels
-priority- High priority refactor Refactor code to improve quality

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Apr 29, 2024

Terms

Issue

Something that would be helpful to do at some point would be to refactor all of the search result components such that CardSearchResult contains all of the styling for the components and is loaded into the other ones. We'd then apply <CardSearchResultTYPE /> in the UI rather than <CardSearchResult /> with an entity passed to it. In this way we'd be able to not have so much code repetition within each of the individual search result components. CardSearchResult would need props for each of the given parts, with these then being styled based on which type of entity is passed (organization, group, etc).

This would be a great good first issue for someone wanting to get into activist coding! Happy to support or work on it myself eventually 😊

@andrewtavis andrewtavis added help wanted Extra attention is needed good first issue Good for newcomers refactor Refactor code to improve quality labels Apr 29, 2024
@andrewtavis andrewtavis moved this from Todo to In Progress in activist Board Apr 29, 2024
@andrewtavis andrewtavis self-assigned this Apr 29, 2024
@andrewtavis
Copy link
Member Author

I'm realizing I should do this such that it's easier to do the links that are needed now in a maintainable way :)

@andrewtavis andrewtavis added -priority- High priority and removed help wanted Extra attention is needed good first issue Good for newcomers labels Apr 29, 2024
andrewtavis added a commit that referenced this issue Apr 29, 2024
@andrewtavis
Copy link
Member Author

Closed via d8bd2b0 🥳

@github-project-automation github-project-automation bot moved this from In Progress to Done in activist Board Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-priority- High priority refactor Refactor code to improve quality
Projects
Archived in project
Development

No branches or pull requests

1 participant