Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated the check_dependency workflow to show dependency report #1131

Merged
merged 9 commits into from
Feb 26, 2025

Conversation

Abhi-Bohora
Copy link
Contributor

linked issue: #1090

The previous workflow didn't gave any information about the dependencies old version, available new version that we can update too, and didn't provide the information about the result of any frontend type checking or formatting. just a little information about mypy check failed mypy check failed Backend tests failed. was only shown.

this now updated workflow will show the following information when actions create the issue.

I try to keep the code less as possible but i have to include little script to compare old deps version and new deps version for both frontend and backend to put them together in a table along with their old version and new available version 😅

Thanks

Contributor checklist


Description

Related issue

  • #ISSUE_NUMBER

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for activist-org canceled.

Name Link
🔨 Latest commit 704a4b3
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/67bf8bb7ca555e00082b4ade

Copy link
Contributor

Thank you for the pull request! ❤️

The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider attending our bi-weekly Saturday developer syncs! It'd be great to meet you 😊

Copy link
Contributor

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review February 26, 2025 14:36
@andrewtavis
Copy link
Member

Thanks, @Abhi-Bohora!! 😊 I'll try to get to the review here in the coming days :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This report that you'd made is a real thing of beauty, @Abhi-Bohora :) Really looking forward to seeing it in action 😊 Thanks for the great conversation around how this should work and an amazing implementation! 🚀

@andrewtavis andrewtavis merged commit 5fe8401 into activist-org:main Feb 26, 2025
7 checks passed
@Abhi-Bohora
Copy link
Contributor Author

@andrewtavis Thank you so much for your help too...😊🎊

@Abhi-Bohora Abhi-Bohora deleted the update-dependency branch February 27, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants