-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated the check_dependency workflow to show dependency report #1131
Conversation
✅ Deploy Preview for activist-org canceled.
|
Thank you for the pull request! ❤️The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
Thanks, @Abhi-Bohora!! 😊 I'll try to get to the review here in the coming days :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This report that you'd made is a real thing of beauty, @Abhi-Bohora :) Really looking forward to seeing it in action 😊 Thanks for the great conversation around how this should work and an amazing implementation! 🚀
@andrewtavis Thank you so much for your help too...😊🎊 |
linked issue: #1090
The previous workflow didn't gave any information about the dependencies old version, available new version that we can update too, and didn't provide the information about the result of any frontend type checking or formatting. just a little information about mypy check failed
mypy check failed Backend tests failed.
was only shown.this now updated workflow will show the following information when actions create the issue.
I try to keep the code less as possible but i have to include little script to compare old deps version and new deps version for both frontend and backend to put them together in a table along with their old version and new available version 😅
Thanks
Contributor checklist
Description
Related issue