Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event creation flow #889

Merged
merged 6 commits into from
Jul 2, 2024

Conversation

Robot8lover
Copy link
Contributor

Contributor checklist


Description

The event create flow is currently incomplete, with the other create flows being further along. This aims to introduce an event create flow design based on the Figma prototype and existing create flows (e.g. for organizations). The basic features including the paged single form design using v-if seem to work. Using a ref with vue models (taken from organizations create flow) enables saving of form data "across" pages, so entries will be populated after moving forwards or backwards. This also makes it easier to send the request data at the end. There are still features and components that will need to be implemented like validation, tooltips, organizer selection, roles, public/private publishing, and invitations.

Also, I think I included the QR code changes in this branch. Sorry about that.

Related issue

Make an event creation flow based on existing create flows. Has some
unimplemented features (validation, tooltips) and components
(organizer selection, roles, public/private, invitation).
Copy link
Contributor

github-actions bot commented May 30, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented May 30, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 94a6ded
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/668346047701f700084efa3c
😎 Deploy Preview https://deploy-preview-889--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewtavis
Copy link
Member

Quick note on this for myself, I need to add in the following for the middleware after #818 is merged :)

definePageMeta({
  middleware: ["user-only"],
});

@andrewtavis andrewtavis self-requested a review May 31, 2024 20:54
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this, @Robot8lover! Such a nice interface 🤩😊 Doubtless some minor changes will be needed as we sync the changes here with the hydration and Pinia store flows, but this is an amazing first step.

@andrewtavis andrewtavis merged commit 68b0361 into activist-org:main Jul 2, 2024
7 checks passed
@andrewtavis andrewtavis mentioned this pull request Jul 2, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants