Tailwind Command Palette basic round-trip functionality #899
Conversation
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mattburnett-repo
changed the title
| <Icon | ||
| :name="IconMap[configObject.iconName as keyof typeof IconMap]" | ||
| size="1em" | ||
| :alt="$t(`_global.${configObject.displayName}`)" |
There was a problem hiding this comment.
I know that this is a bit annoying, @mattburnett-repo, but we can't use variable versions of i18n keys. Not the prettiest of code, but if we use things like this, then we won't be able to track if the keys are used for not via the i18n scripts. I'll give it a quick fix 😊
There was a problem hiding this comment.
Simple as moving _global. to all the displayNames :)
| <ModalBase | ||
| @closeModal="handleCloseModal" | ||
| :isOpen="modalShouldClose == false ? modalIsOpen : false" | ||
| > | ||
| <!-- SEARCH BOX --> |
There was a problem hiding this comment.
For here, @mattburnett-repo, let's start using MARK: so that we get sections in the VS Code minimap 😊 I've started using them recently, and really find that it helps to organize things.
| }; | ||
|
|
||
| // Watch the searchTerm ref variable |
There was a problem hiding this comment.
Personal nitpick for me is periods at the end of own-line comments :) I normally do capitalization and periods at the end if it's its own line, and no capitalization and no period if it's inline 😊
| @@ -0,0 +1,94 @@ | |||
| <!-- TODO: needs to handle focus / tab-to events, get rid of focus ring --> | |||
There was a problem hiding this comment.
Sub directory here should be command-palette :)
There was a problem hiding this comment.
I'm also going to move this to modal as the other ones there have their sub components together (i.e. QR code, etc). Will only be used in the modal, so it's ok to keep it there :)
There was a problem hiding this comment.
Thanks for splitting out the functionality!
There was a problem hiding this comment.
Thanks for the steady work here, @mattburnett-repo! Really great to see this taking such great shape, and also amazing that it's so modular and maintainable 😊 Let's be in touch on next steps soon!
Contributor checklist
Description
Added basic round-trip functionality to Command Palette. Now users can open ComPal with command-K, click a target resource, and the ComPal automatically closes.
Related issue
#666