Basic testing for i18n-check

[andrewtavis]

Terms

• I have searched open and closed feature requests
• I agree to follow activist's Code of Conduct

Description

Once we have the scripts migrated over from activist, the next step would be to add pytest based testing to the directory. We’d want to have some fake data in the testing files with valid and invalid i18n uses and make sure that future changes maintains the current functionality. This will also allow us to guide development in the future when we try to expand the functionality of the package.

Contribution

Happy to work on this and review when a PR is up! 😊

[andrewtavis]

As a part of this, we'd want to use the new YAML file for all check scripts:

• Load in .i18n-check.yaml
• Replace all instances of file_types_to_check, directories_to_skip and files_to_skip with the data from the yaml file

Then we can move on to writing Pytest tests for this :)

[andrewtavis]

@OmarAI2003, don't forget to write in here so I can assign :)

[OmarAI2003]

Here and ready to be assigned! 👍

[andrewtavis]

Assigned! Let me know if you need any support here, @OmarAI2003 :)

[andrewtavis]

Let's start on #5 first and do a PR for that, @OmarAI2003, and then you're welcome to start with this issue. I think that once this one is done you'll have a lot more of an understanding of what the functionality of the CLI will be, and then you'll be ready to work on #4 :)

For the tests, let's load in the testing files via utils as has been done, and then we can assert that all of the checks fail, as the directory has been set up that there's a problem that will fail each one. From there we can expand it, but that level of testing should be enough for the initial release.

[andrewtavis]

I think we're almost done with this here, @OmarAI2003 :) Can you go through the new environment setup and then run mypy ./src --config-file ./pyproject.toml in the project root? From there you'll see 20 or so errors, and once those are fixed we'll be good to close this! You can do one more PR for the needed fixes :)

From there we can maybe do another issue for the tests for the actual i18n-check functionality with the test frontend 😊

[andrewtavis]

I think we're good to close this one and move on to the CLI functionality, @OmarAI2003 😊 From here we can open a new issue for the functionality tests once we know that things are functioning the way we expect them to with the test frontend :)

Thanks for the great step here for i18n-check :)