Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokio 1.0 #1813

Merged
merged 31 commits into from
Jan 3, 2021
Merged

Tokio 1.0 #1813

merged 31 commits into from
Jan 3, 2021

Conversation

fakeshadow
Copy link
Contributor

@fakeshadow fakeshadow commented Dec 5, 2020 •
edited
Loading

PR Type

Update

PR Checklist

Check your PR fulfills the following:

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

Update all cates in actix-web repo to tokio 1.0.

@fakeshadow fakeshadow mentioned this pull request Dec 11, 2020
Closed
@yjhmelody
Copy link

Maybe it is better to wait for tokio 1.0?

@fakeshadow
Copy link
Contributor Author

fakeshadow commented Dec 11, 2020 •
edited
Loading

yea this PR is not meant to be the next release version.

@robjtede robjtede marked this pull request as draft December 11, 2020 21:21
@fakeshadow fakeshadow changed the title Tokio 0.3 Tokio 1.0 Dec 23, 2020
@robjtede robjtede mentioned this pull request Dec 24, 2020
Closed
@bikeshedder bikeshedder mentioned this pull request Dec 26, 2020
Closed
@LukeMathWalker LukeMathWalker mentioned this pull request Dec 28, 2020
Closed
@robjtede robjtede mentioned this pull request Dec 31, 2020
Merged
4 tasks
@therealprof
Copy link
Contributor

@fakeshadow What's the/your timeline for this? Need a hand?

@fakeshadow
Copy link
Contributor Author

fakeshadow commented Dec 31, 2020 •
edited
Loading

@fakeshadow What's the/your timeline for this? Need a hand?

Thanks for asking. This is mostly done with only deps get in the way.
at least actix-service actix-server need a new release to make it pass all CI.
And after that I believe it's ready.

@fakeshadow fakeshadow marked this pull request as ready for review January 3, 2021 05:09
@robjtede robjtede added A-actors project: actix-web-actors A-awc project: awc A-files project: actix-files A-http project: actix-http A-multipart project: actix-multipart A-test-server project: test-server A-web project: actix-web B-semver-major breaking change requiring a major version bump labels Jan 3, 2021
@rubdos rubdos mentioned this pull request Jan 3, 2021
Merged
5 tasks
robjtede
robjtede requested changes Jan 3, 2021
View reviewed changes
Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels like there's some missing changelog items which are easily forgotten

@robjtede robjtede merged commit 32de9f8 into master Jan 3, 2021
@robjtede robjtede deleted the tokio0.3 branch January 3, 2021 23:47
@vicky5124 vicky5124 mentioned this pull request Jan 5, 2021
Closed
@vcfxb vcfxb mentioned this pull request Jun 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

Assignees
No one assigned
Labels
A-actors project: actix-web-actors A-awc project: awc A-files project: actix-files A-http project: actix-http A-multipart project: actix-multipart A-test-server project: test-server A-web project: actix-web B-semver-major breaking change requiring a major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fakeshadow @yjhmelody @therealprof @robjtede