Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Missing is-full-width class #414

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Fix: Missing is-full-width class #414

merged 2 commits into from
Jul 31, 2023

Conversation

simondate
Copy link
Member

@simondate simondate commented Jul 25, 2023 •
edited
Loading

Fixes #390

Fix

  • The class is-full-width was not being applied to the js-btn-marking icon when it should have, meaning that it was appearing in the center, when it should have been to the right of the full width button.

image

Testing

  1. In any question component set _canShowMarking to true and _canShowFeedback to False.
  2. Complete the question and confirm that the icon is on the right
  3. Keep testing with other configurations of these settings to confirm that they all work correctly.

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 1246e10 into master Jul 31, 2023
@oliverfoster oliverfoster deleted the issue/390 branch July 31, 2023 10:08
github-actions bot pushed a commit that referenced this pull request Jul 31, 2023
@semantic-release-bot
Chore(release): 6.38.7
b4cd40e 
## [6.38.7](v6.38.6...v6.38.7) (2023-07-31)

### Fix

* Missing is-full-width class (#414) ([1246e10](1246e10)), closes [#414](#414)
@oliverfoster
Copy link
Member

🎉 This PR is included in version 6.38.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@ethan-lp ethan-lp ethan-lp approved these changes

@eleanor-heath eleanor-heath eleanor-heath approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button validation icons overlapping text
5 participants
@simondate @oliverfoster @cahirodoherty-learningpool @ethan-lp @eleanor-heath