Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: calculate locking on all descendant models #224

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Fix: calculate locking on all descendant models #224

merged 1 commit into from
Jun 11, 2024

Conversation

danielghost
Copy link
Contributor

Fixes #223.
Fixes #164.

Fix

  • Calculate locking on all descendant models to fix issue with incorrect locking for dynamic children order. First model remains _isLocked when content order is randomised.

@danielghost
Fix: calculate locking on all descendant models to fix issue with inc…
0f3b74e 
…orrect locking for dynamic children order (fixes #223, fixes #164).
@danielghost danielghost self-assigned this May 24, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 8276448 into master Jun 11, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/223 branch June 11, 2024 08:45
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
@semantic-release-bot
Chore(release): 7.4.1 [skip ci]
ac3768a 
## [7.4.1](v7.4.0...v7.4.1) (2024-06-11)

### Fix

* Calculate locking on all descendant models to fix issue with incorrect locking for dynamic children order (fixes #223, fixes #164). (#224) ([8276448](8276448)), closes [#223](#223) [#164](#164) [#224](#224)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 7.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-steele chris-steele chris-steele approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@danielghost danielghost

Labels
bug released
Projects
None yet
Milestone
No milestone
4 participants
@danielghost @chris-steele @oliverfoster @cahirodoherty-learningpool