Dark Mac

[JeffryBooher]

FIXED

• [Dark Shell Mac] Slight window repositioning when going full screen on Mac brackets#5602
• [Dark Shell Mac] Secondary windows display standard title bar during transition from full screen brackets#5605

UTR

• [Dark Shell Mac] 10.9 only: Brackets window doesn't resize when exiting Full Screen mode on secondary monitor brackets#5796

BOLO

• Intermittently going full screen will produce a blank screen. I thought this was fixed with a few cocoa calls to unhide and activate the app before going full screen. If you click on the brackets dock icon the appear will appear after going full screen. At that point it is no longer a problem. But the problem is intermittent. I had 10-15 successful launches to full screen without this problem so hopefully the additional NSView setNeedsDisplay:YES call after entering full screen mode fixed it but it's hard to say. I'd say since there is a work-around then let's roll with it and, if it's reproducible, then file a bug and we'll address it in the usual way. I don't think it's a show stopper unless it reproduces with great frequency.

[jasonsanjose]

Update copyright:

/*
 * Copyright (c) 2013 Adobe Systems Incorporated. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.
 */

[jasonsanjose]

Refactor 4 to a constant

[jasonsanjose]

I did a high level review, but I can't say much about the Cocoa usage.

[redmunds]

Why is this file extension .m and all the other Cocoa files seem to be .mm ?

[bobeast]

Generally speaking, only files which contain both Objective-C AND c++ should use the .mm extension. Purely Obj-C files should use .m. It really doesn't cause runtime issues either way, but over use of .mm does slow down compile times.

[redmunds]

@bobeast Thanks for the explanation. Now I know which files I shouldn't touch :) .

[bobeast]

Once the dust settles, I highly recommend refactoring such that each class gets its own file pair, as opposed to placing multiple classes in a single file.

[redmunds]

Merging.