Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Some dialogs have text that renders poorly on Windows #4567

Closed
njx opened this issue Jul 25, 2013 · 8 comments
Closed

Some dialogs have text that renders poorly on Windows #4567

njx opened this issue Jul 25, 2013 · 8 comments

Comments

@njx
Copy link

njx commented Jul 25, 2013

Last sprint we worked around #4554 (Extension Manager font is hard to read on Windows) by increasing the weight of the font slightly. However, we didn't do the same for other dialogs. In a number of dialogs (like the About box and Project Settings), the text is larger, so it seems less critical, but it still doesn't look great, and some dialogs (like the unsaved changes confirmation dialog) use smaller text, so we should consider increasing the weight on Windows there as well.

@ghost ghost assigned larz0 Jul 25, 2013
@njx
Copy link
Author

njx commented Jul 25, 2013

To @larz0 to consider, medium priority for Sprint 29.

Also, is there a reason why we made the font in the unsaved changes dialog smaller, but not the fonts in About or Project Settings? Seems inconsistent.

@larz0
Copy link
Member

larz0 commented Jul 25, 2013

@njx let's apply the same changes to the dialogs.

The font sizes in dialogs are all 14px, the only inconsistency is that About dialog's line-height is 17px instead of 20px like all the other dialogs so that we can see the first line of contributors instead of feeling like it's been cut off abruptly.

@peterflynn
Copy link
Member

@njx Yeah, I think the sizes were actually inconsistent before Sprint 28, with About & Project Settings being several px smaller than confirmation dialogs -- so @larz0's recent change just made the sizes equal.

@peterflynn
Copy link
Member

Reviewed. To me to try out a workaround similar to what we did for Extension Manager in #4554.

Note: the master tracking bug for these issues is #4568. We can roll back all these workarounds if the Chromium bug/"feature" is ever fixed.

@ghost ghost assigned peterflynn Aug 5, 2013
@JeffryBooher
Copy link
Contributor

Moving this to Sprint 30 to be reviewed when the new CEF.

@njx
Copy link
Author

njx commented Aug 8, 2013

This is still listed on the bug card--should we remove it?

peterflynn added a commit that referenced this issue Aug 27, 2013
… the

worst offenders similar to #4554, making the font weight heavier and
tweaking the text color to match Mac more closely.
JeffryBooher added a commit that referenced this issue Aug 27, 2013
Workaround for #4567 (Dialog text renders poorly on Windows)
@dangoor
Copy link
Contributor

dangoor commented Aug 28, 2013

This is now fixed but not closed, correct?

@peterflynn
Copy link
Member

Actually, since I was the filer too I'll just go ahead & close it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants