Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[Code Inspection] It's not always possible to get the code snippet #6441

Closed
busykai opened this issue Jan 9, 2014 · 2 comments
Closed

[Code Inspection] It's not always possible to get the code snippet #6441

busykai opened this issue Jan 9, 2014 · 2 comments
Assignees

Comments

@busykai
Copy link
Contributor

busykai commented Jan 9, 2014

Some linting providers (most notably JSHint) may report negative line number Indicating general provide problem. For example, it may happen when there's an internal code inspection provider (e.g. configuration file is broken). Currently, it causes a crash in code inspection:

Uncaught TypeError: Cannot read property 'length' of undefined CodeInspection.js:312

While there's a protection against NaN (recently added), there's no check for negative numbers so that code snippet could be retrieved from the current editor.

@ghost ghost assigned peterflynn Jan 13, 2014
@dangoor
Copy link
Contributor

dangoor commented Jan 13, 2014

Medium priority to @peterflynn to take a look at the fix and see if @busykai should submit a pull request for that

@dangoor
Copy link
Contributor

dangoor commented Jan 13, 2014

Oops #6442 is the pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants