Close CSS Code Hints after inputting property value

[marcelgerber]

For #9496 and #4888

[nethip]

@marcelgerber Just a small thing. To adhere to how it is done everywhere can you change this to return null.

[marcelgerber]

Fixed (& rebased)

[nethip]

@marcelgerber I took this change and it does not seem to solve #9496. I am not sure if this makes the issue better though.

[marcelgerber]

Hm, it definitely works for me. So, just to be sure, these are the steps I followed:

1. Type position: absolute;
2. Place your mouse before the p
3. Type (without using Code Hints!) left: auto; - without a trailing space
4. Press Enter

Before: left: auto;align-content: : absolute;
After: left: auto;[Newline]position: absolute;

[kylelondonuk]

Hi, I opened issue #9496 and was wondering whether this fix is available yet? the problem still seems to exist in Brackets 1.3 downloaded today.

Cheers

[nethip]

@kylelondonuk This is not merged yet.

[ficristo]

FWIW I can confirm the STR above and this PR fixes it.

[marcelgerber]

I do think this fix should be reviewed soon. Would you mind? Maybe @abose?

[ficristo]

There is a test failing under Extensions \ CSS Code Hinting. Could you take a look?

By the way I'd write the code like the following: I find it easier to read.

-            lastContext = CSSUtils.PROP_NAME;
+            if (lastContext === CSSUtils.PROP_VALUE) {
+                // Close the session if we're coming from a property value.
+                // See https://github.com/adobe/brackets/issues/9496
+                return null;
+            }
+
+            lastContext = CSSUtils.PROP_NAME;
             needle = needle.substr(0, this.info.offset);

[marcelgerber]

@ficristo With latest master merged in, all tests pass for me.
I've also incorporated your suggested code style change.

[ficristo]

You are missing a brace.

[marcelgerber]

Argh, yesterday simply wasn't my day. Fixed it now and squashed the commits as.
Should be good to go after one last look.

[ficristo]

Thank you, LGTM.