Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Rework how file selection is shown #12636

Merged
merged 2 commits into from
Aug 16, 2016
Merged

Conversation

marcelgerber
Copy link
Contributor

This PR includes two changes:

  • The dark background element behind the currently selected file in both the file tree and Working Files has his width now handled by CSS (turns out that's a whole lot easier than to have React update it on every change)
  • Upon resizing the panel, the tree is rendered without delay, that is, the "selection extension" that covers the dark scrollbars is always in the right place. Fixes SidebarView resize shows ghost of File List selection in editor pane #11341.

@ficristo ficristo added this to the Release 1.8 milestone Aug 2, 2016
@ficristo
Copy link
Collaborator

ficristo commented Aug 9, 2016

LGTM after testing briefly.
Maybe @petetnt could take a look too?

/cc @humphd because it seems to me he has fixed the same problem in a different way so he is aware of this change.

@zaggino
Copy link
Contributor

zaggino commented Aug 16, 2016

Reviewed & tested. Fixes referenced issue so merging.

@zaggino zaggino merged commit 271943a into master Aug 16, 2016
@zaggino zaggino deleted the marcel/rework-tree-selection branch August 16, 2016 06:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants