Avoid the edit icon to move in the file exclusion set #12671
Conversation
|
No, the window is at full size and has been at this size the whole time. |
ficristo
force-pushed
the
fix-filter-pencil-pos
branch
from
ac3b303 to
b3107af
Compare
|
With latest changes I should have fixed your issue too. But still not #10962. |
| @@ -264,14 +264,19 @@ define(function (require, exports, module) { | |||
| posTop = Math.max(0, toggleOffset.top - $dropdown.height() - 4); | |||
| } | |||
|
|
|||
| // Take in consideration the scrollbar to prevent the edit icon to move down. See #10963 | |||
There was a problem hiding this comment.
Maybe we shouldn't mention the edit icon here because DropdownButton is far more versatile.
I'd go for something along the lines of Take the scrollbar into consideration so we don't get unintented line breaks (see #10963)
|
Thanks! LGTM now and handles both issues indeed |
| @@ -264,14 +264,19 @@ define(function (require, exports, module) { | |||
| posTop = Math.max(0, toggleOffset.top - $dropdown.height() - 4); | |||
| } | |||
|
|
|||
| // Take in consideration the scrollbar to prevent the edit icon to move down. See #10963 | |||
| var dropdownElement = this.$dropdown[0]; | |||
| var scrollWidth = dropdownElement.offsetWidth - dropdownElement.clientWidth + 1; | |||
There was a problem hiding this comment.
Also, where does the + 1 come from? Is it just a safety measure so we have a tiny little more space available or does it serve a real purpose?
ficristo
force-pushed
the
fix-filter-pencil-pos
branch
from
b3107af to
762d2b7
Compare
|
Actually that 1 pixel is the fix! |
|
Thank you! |
|
Thank you for all the reviews. |
This should fix or at least help with #10963